From 5115ffa90c959086704b6e3437214a192de7b8a7 Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Tue, 4 Apr 2023 08:47:23 +0800 Subject: [PATCH] Remove fomantic ".link" selector and styles (#23888) It's difficult to play with Fomantic's ".link" selector&styles, and it doesn't bring any real benefit. Instead, it sometimes introduces regressions (because of the `:not` selector, really difficult to fine-tune). Regression:
![image](https://user-images.githubusercontent.com/2114189/229421849-b48fbcf6-2ae2-4264-b06b-2a06c12e1a4b.png)
After this PR, there is no ".link" in code anymore. We do not need to play the overwriting and `:not()` game anymore. ![image](https://user-images.githubusercontent.com/2114189/229422058-476aa5e2-53db-402d-b507-a6063824f835.png) ![image](https://user-images.githubusercontent.com/2114189/229422435-34fde1bc-b2ec-48ec-8c4a-6d8c2610b249.png) ![image](https://user-images.githubusercontent.com/2114189/229422014-cb38c8c7-828f-4a49-a761-95ea824d46a7.png) ![image](https://user-images.githubusercontent.com/2114189/229422031-10f6b4a5-af76-40ee-8fa1-692112a9274f.png) --- templates/repo/forks.tmpl | 18 ++++++------------ templates/repo/sub_menu.tmpl | 4 ++-- templates/user/dashboard/navbar.tmpl | 4 ++-- web_src/css/base.css | 23 +---------------------- web_src/css/repository.css | 19 ------------------- 5 files changed, 11 insertions(+), 57 deletions(-) diff --git a/templates/repo/forks.tmpl b/templates/repo/forks.tmpl index b05ebcc63..13810b44d 100644 --- a/templates/repo/forks.tmpl +++ b/templates/repo/forks.tmpl @@ -5,18 +5,12 @@

{{.locale.Tr "repo.forks"}}

-
- {{range .Forks}} -
- {{avatar $.Context .Owner}} - -
- {{end}} -
+ {{range .Forks}} +
+ {{avatar $.Context .Owner}} + {{.Owner.Name}} / {{.Name}} +
+ {{end}} {{template "base/paginate" .}} diff --git a/templates/repo/sub_menu.tmpl b/templates/repo/sub_menu.tmpl index fe4148d74..97fbabda4 100644 --- a/templates/repo/sub_menu.tmpl +++ b/templates/repo/sub_menu.tmpl @@ -1,7 +1,7 @@ {{if and (not .HideRepoInfo) (not .IsBlame)}}