Hri7566
/
gitea
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Make TestOneDevDownloadRepo work again & more resistant (#16987) 

* Update TestOneDevDownloadRepo since OneDev api changed

* Use test functions for migrations
This commit is contained in:
6543 2021-09-08 16:17:22 +02:00 committed by GitHub
parent bc81d12e68
commit f55cd033ed
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
modules/migrations/onedev_test.go
View File

@ -30,7 +30,7 @@ func TestOneDevDownloadRepo(t *testing.T) {
} }
repo, err := downloader.GetRepoInfo() repo, err := downloader.GetRepoInfo()
assert.NoError(t, err) assert.NoError(t, err)
assert.EqualValues(t, &base.Repository{ assertRepositoryEqual(t, &base.Repository{
Name: "go-gitea-test_repo", Name: "go-gitea-test_repo",
Owner: "", Owner: "",
Description: "Test repository for testing migration from OneDev to gitea", Description: "Test repository for testing migration from OneDev to gitea",
@ -40,9 +40,8 @@ func TestOneDevDownloadRepo(t *testing.T) {
milestones, err := downloader.GetMilestones() milestones, err := downloader.GetMilestones()
assert.NoError(t, err) assert.NoError(t, err)
assert.Len(t, milestones, 2)
deadline := time.Unix(1620086400, 0) deadline := time.Unix(1620086400, 0)
assert.EqualValues(t, []*base.Milestone{ assertMilestonesEqual(t, []*base.Milestone{
{ {
Title: "1.0.0", Title: "1.0.0",
Deadline: &deadline, Deadline: &deadline,
@ -60,9 +59,8 @@ func TestOneDevDownloadRepo(t *testing.T) {
issues, isEnd, err := downloader.GetIssues(1, 2) issues, isEnd, err := downloader.GetIssues(1, 2)
assert.NoError(t, err) assert.NoError(t, err)
assert.Len(t, issues, 2)
assert.False(t, isEnd) assert.False(t, isEnd)
assert.EqualValues(t, []*base.Issue{ assertIssuesEqual(t, []*base.Issue{
{ {
Number: 4, Number: 4,
Title: "Hi there", Title: "Hi there",
@ -112,21 +110,19 @@ func TestOneDevDownloadRepo(t *testing.T) {
}, },
}) })
assert.NoError(t, err) assert.NoError(t, err)
assert.Len(t, comments, 1) assertCommentsEqual(t, []*base.Comment{
assert.EqualValues(t, []*base.Comment{
{ {
IssueIndex: 4, IssueIndex: 4,
PosterName: "User 336", PosterName: "User 336",
Created: time.Unix(1628549791, 128000000), Created: time.Unix(1628549791, 128000000),
Updated: time.Unix(1628549791, 128000000), Updated: time.Unix(1628549791, 128000000),
Content: "it has a comment\r\n\r\nEDIT: that got edited", Content: "it has a comment\n\nEDIT: that got edited",
}, },
}, comments) }, comments)
prs, _, err := downloader.GetPullRequests(1, 1) prs, _, err := downloader.GetPullRequests(1, 1)
assert.NoError(t, err) assert.NoError(t, err)
assert.Len(t, prs, 1) assertPullRequestsEqual(t, []*base.PullRequest{
assert.EqualValues(t, []*base.PullRequest{
{ {
Number: 5, Number: 5,
Title: "Pull to add a new file", Title: "Pull to add a new file",
@ -158,8 +154,7 @@ func TestOneDevDownloadRepo(t *testing.T) {
localID: 5, localID: 5,
}) })
assert.NoError(t, err) assert.NoError(t, err)
assert.Len(t, rvs, 1) assertReviewsEqual(t, []*base.Review{
assert.EqualValues(t, []*base.Review{
{ {
IssueIndex: 5, IssueIndex: 5,
ReviewerName: "User 317", ReviewerName: "User 317",