bf847b9397
Upgrade golangci-lint to 1.24.0 ( #10894 )
...
* upgrade golangci-lint to 1.24.0 to allow go 1.14 compatibility
* fix golangci-lint errors
* make make golangci-lint work when out of go-path
Signed-off-by: Andrew Thornton <art27@cantab.net>
2020-03-30 21:52:45 +03:00
d01763ee14
Protect against NPEs in notifications list ( #10879 )
...
Unfortunately there appears to be potential race with notifications
being set before the associated issue has been committed.
This PR adds protection in to the notifications list to log any failures
and remove these notifications from the display.
References #10815 - and prevents the panic but does not completely fix
this.
Signed-off-by: Andrew Thornton <art27@cantab.net>
2020-03-29 20:51:14 +01:00
694f44660f
inform participants on UI too ( #10473 )
...
* inform participants on UI too
* ajust test
* refactor getParticipantIDsByIssue
2020-02-28 05:16:41 -03:00
e57ac841de
Fix potential bugs ( #10513 )
...
* use e if it is an option
* potential nil so check err first
* check err first
* m == nil already checked
2020-02-27 20:10:27 -03:00
084a2b0026
Code Refactor of IssueWatch related things ( #10401 )
...
* refactor
* optimize
* remove Iretating function
LoadWatchUsers do not load Users into IW object and it is used only in api ... so move this logic
* remove unessesary
* Apply suggestions from code review
Thx
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* make Tests more robust
* fix rebase
* restart CI
* CI no dont hit sqlites deadlock
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
2020-02-26 03:32:22 -03:00
1f01f53c53
API add/generalize pagination ( #9452 )
...
* paginate results
* fixed deadlock
* prevented breaking change
* updated swagger
* go fmt
* fixed find topic
* go mod tidy
* go mod vendor with go1.13.5
* fixed repo find topics
* fixed unit test
* added Limit method to Engine struct; use engine variable when provided; fixed gitignore
* use ItemsPerPage for default pagesize; fix GetWatchers, getOrgUsersByOrgID and GetStargazers; fix GetAllCommits headers; reverted some changed behaviors
* set Page value on Home route
* improved memory allocations
* fixed response headers
* removed logfiles
* fixed import order
* import order
* improved swagger
* added function to get models.ListOptions from context
* removed pagesize diff on unit test
* fixed imports
* removed unnecessary struct field
* fixed go fmt
* scoped PR
* code improvements
* code improvements
* go mod tidy
* fixed import order
* fixed commit statuses session
* fixed files headers
* fixed headers; added pagination for notifications
* go mod tidy
* go fmt
* removed Private from user search options; added setting.UI.IssuePagingNum as default valeu on repo's issues list
* Apply suggestions from code review
Co-Authored-By: 6543 <6543@obermui.de>
Co-Authored-By: zeripath <art27@cantab.net>
* fixed build error
* CI.restart()
* fixed merge conflicts resolve
* fixed conflicts resolve
* improved FindTrackedTimesOptions.ToOptions() method
* added backwards compatibility on ListReleases request; fixed issue tracked time ToSession
* fixed build error; fixed swagger template
* fixed swagger template
* fixed ListReleases backwards compatibility
* added page to user search route
Co-authored-by: techknowlogick <matti@mdranta.net>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: zeripath <art27@cantab.net>
2020-01-24 14:00:29 -05:00
44de66bf50
[API] add endpoint to check notifications [Extend #9488 ] ( #9595 )
...
* introduce GET /notifications/new
* add TEST
* use Sprintf instead of path.Join
* Error more verbose
* return number of notifications if unreaded exist
* 200 http status for available notifications
2020-01-14 16:37:19 +01:00
6baa5d7588
[API] Add notification endpoint ( #9488 )
...
* [API] Add notification endpoints
* add func GetNotifications(opts FindNotificationOptions)
* add func (n *Notification) APIFormat()
* add func (nl NotificationList) APIFormat()
* add func (n *Notification) APIURL()
* add func (nl NotificationList) APIFormat()
* add LoadAttributes functions (loadRepo, loadIssue, loadComment, loadUser)
* add func (c *Comment) APIURL()
* add func (issue *Issue) GetLastComment()
* add endpoint GET /notifications
* add endpoint PUT /notifications
* add endpoint GET /repos/{owner}/{repo}/notifications
* add endpoint PUT /repos/{owner}/{repo}/notifications
* add endpoint GET /notifications/threads/{id}
* add endpoint PATCH /notifications/threads/{id}
* Add TEST
* code format
* code format
2020-01-09 11:56:32 +00:00
27f68bc96f
Fix notification page panic ( #9337 )
2019-12-13 03:08:34 +01:00
bb6879d339
Improve notification ( #8835 )
...
* Improve notifications
* batch load user
* Update notification only when read
* Fix reorder
* fix lint
* fix test
* fix lint
* make function meaningful
* fix comment
2019-11-12 16:33:34 +08:00
85202d4784
Display ui time with customize time location ( #7792 )
...
* display ui time with customize time location
* fix lint
* rename UILocation to DefaultUILocation
* move time related functions to modules/timeutil
* fix tests
* fix tests
* fix build
* fix swagger
2019-08-15 22:46:21 +08:00
f9ec2f89f2
Add golangci ( #6418 )
2019-06-12 15:41:28 -04:00
5f938c0c78
Fix sqlite lock ( #5176 )
...
* fix sqlite lock
* fix sqlite lock on getUnitType
2018-10-25 18:55:16 +08:00
0b3ea42847
hide issues from org private repos w/o team assignment ( #4034 )
2018-06-21 12:00:13 -04:00
f2e20c81b6
Refactor struct's time to remove unnecessary memory usage ( #3142 )
...
* refactor struct's time to remove unnecessary memory usage
* use AsTimePtr simple code
* fix tests
* fix time compare
* fix template on gpg
* use AddDuration instead of Add
2017-12-11 06:37:04 +02:00
7ec6cddd27
Add 'mark all read' option to notifications ( #3097 )
...
* Add 'mark all read' option to notifications
Signed-off-by: Sasha Varlamov <sasha@sashavarlamov.com>
* Fix exported comment
Signed-off-by: Sasha Varlamov <sasha@sashavarlamov.com>
* Format method comments
Signed-off-by: Sasha Varlamov <sasha@sashavarlamov.com>
* Fix exported comment
Signed-off-by: Sasha Varlamov <sasha@sashavarlamov.com>
Format method comments
Signed-off-by: Sasha Varlamov <sasha@sashavarlamov.com>
Tests for reactions (#3083 )
* Unit tests for reactions
* Fix import order
Signed-off-by: Lauris Bukšis-Haberkorns <lauris@nix.lv>
Fix reaction possition when there is attachments (#3099 )
Refactor notifications swap function
* Accept change to drop beforeupdate call
* Update purge notifications error message for consistency
* Drop unnecessary check for mark all as read button
* Remove debugging comment
2017-12-07 13:52:57 +08:00
aa962deec0
Replace deprecated Id method with ID ( #2655 )
2017-10-05 07:43:04 +03:00
aa6e949b3d
Consider issue_watchers while sending notifications
2017-03-29 20:54:57 -03:00
46320f9630
refactor notificationsForUser since xorm In support slice of customerize type ( #956 )
2017-02-16 12:07:00 +08:00
2eb15f4a61
Unit tests and remove unused functions in models/notification ( #796 )
...
* Unit tests and remove unused functions in models/notification
* Read -> Unread
2017-01-30 22:21:49 +08:00
769e0a3ea6
Notifications: mark as read/unread and pin ( #629 )
...
* Use relative URLs
* Notifications - Mark as read/unread
* Feature of pinning a notification
* On view issue, do not mark as read a pinned notification
2017-01-12 12:27:09 +08:00
79d527195d
Merge pull request #539 from andreynering/notifications-step-2
...
Notifications - Step 2
2017-01-05 11:53:01 -02:00
1207bda94b
Fix typos in models/ ( #576 )
2017-01-05 08:50:34 +08:00
b354cf362e
Add pagination for notifications
2017-01-03 17:09:36 -02:00
42904cb98a
Notification - Step 1 ( #523 )
...
* Notification - Step 1
* Add copyright headers
* Cache issue and repository on notification model
2016-12-31 00:44:54 +08:00
zeripath
6543
SpaWn2KiLl
jaqra
Lunny Xiao
kolaente
David Schneiderbauer
Sasha Varlamov
Ethan Koenig
Andrey Nering
Ethan Koenig