Hri7566
/
gitea
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity
gitea/modules
History
wxiaoguang b9a97ccd0e
Refactor web route (#24080) 
The old code is unnecessarily complex, and has many misuses.

Old code "wraps" a lot, wrap wrap wrap, it's difficult to understand
which kind of handler is used.

The new code uses a general approach, we do not need to write all kinds
of handlers into the "wrapper", do not need to wrap them again and
again.

New code, there are only 2 concepts:

1. HandlerProvider: `func (h any) (handlerProvider func (next)
http.Handler)`, it can be used as middleware
2. Use HandlerProvider to get the final HandlerFunc, and use it for
`r.Get()`


And we can decouple the route package from context package (see the
TODO).

# FAQ

## Is `reflect` safe?

Yes, all handlers are checked during startup, see the `preCheckHandler`
comment. If any handler is wrong, developers could know it in the first
time.

## Does `reflect` affect performance?

No. https://github.com/go-gitea/gitea/pull/24080#discussion_r1164825901

1. This reflect code only runs for each web handler call, handler is far
more slower: 10ms-50ms
2. The reflect is pretty fast (comparing to other code): 0.000265ms
3. XORM has more reflect operations already
 		2023-04-20 14:49:06 -04:00
..
actions Support triggering workflows by wiki related events (#24119) 2023-04-17 13:49:47 -04:00
activitypub Add Chef package registry (#22554) 2023-02-06 09:49:21 +08:00
analyze
…
assetfs Use a general approach to access custom/static/builtin assets (#24022) 2023-04-12 18:16:45 +08:00
auth Use a general approach to access custom/static/builtin assets (#24022) 2023-04-12 18:16:45 +08:00
avatar Use minio/sha256-simd for accelerated SHA256 (#23052) 2023-02-22 14:21:46 -05:00
base Use a general Eval function for expressions in templates. (#23927) 2023-04-07 21:25:49 +08:00
cache Update redis library to support redis v7 (#24114) 2023-04-13 18:41:04 -04:00
charset Refactor locale number (#24134) 2023-04-17 11:37:23 +08:00
container
…
context Make HTML template functions support context (#24056) 2023-04-20 04:08:58 -04:00
csv Refactor locale number (#24134) 2023-04-17 11:37:23 +08:00
doctor Use a general approach to access custom/static/builtin assets (#24022) 2023-04-12 18:16:45 +08:00
emoji Fix unstable emoji sort (#22346) 2023-01-05 13:58:51 +02:00
eventsource Move `convert` package to services (#22264) 2022-12-29 10:57:15 +08:00
generate
…
git Make wiki title supports dashes and improve wiki name related features (#24143) 2023-04-19 13:50:10 -04:00
gitgraph Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
graceful Remove most path-based golangci exclusions (#24214) 2023-04-19 22:08:01 -04:00
hcaptcha Consume hcaptcha and pwn deps (#22610) 2023-01-29 09:49:51 -06:00
highlight test_env: hardcode major go version in use (#23464) 2023-03-14 16:09:01 -04:00
hostmatcher
…
html
…
httpcache Set `X-Gitea-Debug` header once (#23361) 2023-03-08 15:40:04 -05:00
httplib Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" (#23687) 2023-03-29 14:32:26 +08:00
indexer Allow adding new files to an empty repo (#24164) 2023-04-19 21:40:42 +08:00
issue/template Allow issue templates to not render title (#22589) 2023-01-26 22:45:49 -06:00
json
…
label Make label templates have consistent behavior and priority (#23749) 2023-04-10 16:44:02 +08:00
lfs Make minio package support legacy MD5 checksum (#23768) 2023-03-28 11:10:24 -04:00
log Remove most path-based golangci exclusions (#24214) 2023-04-19 22:08:01 -04:00
markup Improve Wiki TOC (#24137) 2023-04-17 15:05:19 -04:00
mcaptcha
…
metrics include build info in Prometheus metrics (#22819) 2023-02-08 19:54:01 +02:00
migration Scoped labels (#22585) 2023-02-18 21:17:39 +02:00
mirror
…
nosql Update redis library to support redis v7 (#24114) 2023-04-13 18:41:04 -04:00
notification Implement actions (#21937) 2023-01-31 09:45:19 +08:00
options Use a general approach to access custom/static/builtin assets (#24022) 2023-04-12 18:16:45 +08:00
packages Display image size for multiarch container images (#23821) 2023-04-02 17:53:37 +08:00
paginator
…
pprof
…
private Fix incorrect internal response type (#24173) 2023-04-17 23:10:40 -04:00
process Improve trace logging for pulls and processes (#22633) 2023-02-03 18:11:48 -05:00
proxy Use proxy for pull mirror (#22771) 2023-02-11 08:39:50 +08:00
proxyprotocol
…
public Use a general approach to access custom/static/builtin assets (#24022) 2023-04-12 18:16:45 +08:00
queue Update redis library to support redis v7 (#24114) 2023-04-13 18:41:04 -04:00
recaptcha
…
references Use correct captured group range when parsing cross-reference (#22672) 2023-01-31 10:08:05 +01:00
regexplru
…
repository Use a general approach to access custom/static/builtin assets (#24022) 2023-04-12 18:16:45 +08:00
secret Use minio/sha256-simd for accelerated SHA256 (#23052) 2023-02-22 14:21:46 -05:00
session Update redis library to support redis v7 (#24114) 2023-04-13 18:41:04 -04:00
setting Fix incorrect CORS default values (#24206) 2023-04-19 15:30:10 -04:00
sitemap Fix sitemap (#22272) 2022-12-30 23:31:00 +08:00
ssh
…
storage Make minio package support legacy MD5 checksum (#23768) 2023-03-28 11:10:24 -04:00
structs Fix Org edit page bugs: renaming detection, maxlength (#24161) 2023-04-17 11:35:57 -04:00
svg Use a general approach to access custom/static/builtin assets (#24022) 2023-04-12 18:16:45 +08:00
sync
…
system
…
templates Make HTML template functions support context (#24056) 2023-04-20 04:08:58 -04:00
test Make HTML template functions support context (#24056) 2023-04-20 04:08:58 -04:00
timeutil Remove untranslatable `on_date` key (#24106) 2023-04-15 13:01:54 +02:00
translation Refactor locale number (#24134) 2023-04-17 11:37:23 +08:00
turnstile Add new captcha: cloudflare turnstile (#22369) 2023-02-05 15:29:03 +08:00
typesniffer Do not recognize text files as audio (#23355) 2023-03-07 22:40:41 -05:00
updatechecker
…
upload
…
uri
…
user
…
util Use a general approach to access custom/static/builtin assets (#24022) 2023-04-12 18:16:45 +08:00
validation Map OIDC groups to Orgs/Teams (#21441) 2023-02-08 14:44:42 +08:00
web Refactor web route (#24080) 2023-04-20 14:49:06 -04:00
webhook Restructure `webhook` module (#22256) 2023-01-01 23:23:15 +08:00